[Ocfs2-tools-devel] [PATCH 1/9] dx_dirs: stop iterate dir entries for I/O error

[Coly Li]

On 04/27/2010 09:24 AM, Tao Ma Wrote:
> Hi coly,
>     The patch looks good. Only small comments.
> 
> Coly Li wrote:
[snip]
>>  static int dx_iterator(ocfs2_filesys *fs,
>> @@ -330,7 +331,7 @@ static int dx_iterator(ocfs2_filesys *fs,
>>                 int ref_recno,
>>                 void *priv_data)
>>  {
>> -    int ret, i;
>> +    int err, i;
> I guess err should be errcode_t.

Yeah, it is errcode_t. Fixed.

[snip]
>> diff --git a/libocfs2/extents.c b/libocfs2/extents.c
>> index 8c322b1..bb233f0 100644
>> --- a/libocfs2/extents.c
>> +++ b/libocfs2/extents.c
>> @@ -470,7 +470,7 @@ errcode_t ocfs2_extent_iterate_inode(ocfs2_filesys
>> *fs,
>>                               uint64_t ref_blkno,
>>                               int ref_recno,
>>                               void *priv_data),
>> -                             void *priv_data)
>> +                     void *priv_data)
> why you want to change this?
> 

This is a fix for indent. Why I change this is, for 8 characters indent, parameter 'void *priv_data' of
ocfs2_extent_iterate_inode() starts at same column to parameter 'void *priv_data' of callback func(). Which confused me
to understand the code mistakenly. And other similar functions do not place its argument and its callback argument'
argument at same indent.

-- 
Coly Li
SuSE Labs