[Ocfs2-tools-devel] [PATCH 4/6] O2info: Add running codes for '--fs-features'.

[tristan]

Joel Becker wrote:
> On Mon, Apr 26, 2010 at 02:35:46PM +0800, tristan wrote:
>   
>> Joel Becker wrote:
>> Here we only set the FL_ERROR to denote whether an error happened or
>> not, we're not going to record the type of error, so why bother to
>> add a new req.ir_error? can't it be just set in req.ir_flags?
>>     
>
> 	You need ir_error to tell the error on the particular request.
> If request N had an error of -EINVAL and request N+1 had an error of
> -EFAULT, how do you differentiate?
>   

oh you mean:

ir.ir_flags |= OCFS2_INFO_FL_ERROR;
ir.ir_error = REAL_ERROR_CODE;

when orror occurs.



> Joel
>
>