[Ocfs2-tools-devel] [PATCH 01/15] dx_dirs v11: Add library support for directory indexing

[Coly Li]

On 04/23/2010 02:47 PM, Tao Ma Wrote:
> Hi Coly/Mark,
>     Sorry for the delay.
> 

Thanks for the review :-)

> Coly Li wrote:
>> diff --git a/libocfs2/feature_string.c b/libocfs2/feature_string.c
>> index 7021dba..0974fb6 100644
>> --- a/libocfs2/feature_string.c
>> +++ b/libocfs2/feature_string.c
>> @@ -89,7 +89,8 @@ static ocfs2_fs_options feature_level_defaults[] = {
>>       OCFS2_FEATURE_INCOMPAT_INLINE_DATA |
>>       OCFS2_FEATURE_INCOMPAT_META_ECC |
>>       OCFS2_FEATURE_INCOMPAT_XATTR |
>> -     OCFS2_FEATURE_INCOMPAT_REFCOUNT_TREE,
>> +     OCFS2_FEATURE_INCOMPAT_REFCOUNT_TREE |
>> +     OCFS2_FEATURE_INCOMPAT_INDEXED_DIRS,
>>       OCFS2_FEATURE_RO_COMPAT_UNWRITTEN |
>>       OCFS2_FEATURE_RO_COMPAT_USRQUOTA |
>>       OCFS2_FEATURE_RO_COMPAT_GRPQUOTA }, /*
>> OCFS2_FEATURE_LEVEL_MAX_FEATURES */
>> @@ -165,6 +166,11 @@ static struct fs_feature_flags
>> ocfs2_supported_features[] = {
>>          {0, OCFS2_FEATURE_INCOMPAT_XATTR, 0},
>>          {0, OCFS2_FEATURE_INCOMPAT_XATTR, 0},
>>      },
>> +     {
>> +        "indexed-dirs",
>> +        {0, OCFS2_FEATURE_INCOMPAT_INDEXED_DIRS, 0},
>> +        {0, OCFS2_FEATURE_INCOMPAT_INDEXED_DIRS, 0},
>> +    },
>>      {
>>          "usrquota",
>>          {0, 0, OCFS2_FEATURE_RO_COMPAT_USRQUOTA},
>> @@ -247,6 +253,10 @@ static struct feature_name ocfs2_feature_names[] = {
>>          .fn_name = "xattr",
>>          .fn_flag = {0, OCFS2_FEATURE_INCOMPAT_XATTR, 0},
>>      },
>> +     {
>> +        .fn_name = "IndexedDirs",
>> +        .fn_flag = {0, OCFS2_FEATURE_INCOMPAT_INDEXED_DIRS, 0},
> I remembered that now we required both featurn strings should have the
> same name. Here one is "indexed-dirs", the other is "IndexedDirs".

I notice this too. Mark originally proposed the feature strings. Using indexed-dirs is OK for me.

Mark, how to you think about it ?


-- 
Coly Li
SuSE Labs