[Ocfs2-tools-devel] [PATCH 06/22] libocfs2: Make ocfs2_init_group_desc aware of discontig group.

Joel Becker Joel.Becker at oracle.com
Thu Apr 1 17:19:41 PDT 2010


On Fri, Apr 02, 2010 at 08:08:17AM +0800, Tao Ma wrote:
> check offset(bg_bitmap) + bg_size == offsetof(bg_list)
> =>
> check bg_size== OCFS2_MAX_BG_BITMAP_SIZE .

	Of course it equals OCFS2_MAX_BG_BITMAP_SIZE.  But check against
the offsets in the code, not against the constant.

Joel

-- 

Bram's Law:
	The easier a piece of software is to write, the worse it's
	implemented in practice.

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127



More information about the Ocfs2-tools-devel mailing list