[Ocfs2-tools-devel] [PATCH 05/22] libocfs2: Add functions for read/write discontig groups.

[Tao Ma]

Joel Becker wrote:
> On Thu, Apr 01, 2010 at 12:41:09PM +0800, Tao Ma wrote:
>> diff --git a/libocfs2/chain.c b/libocfs2/chain.c
>> index e9d3873..039ddaf 100644
>> --- a/libocfs2/chain.c
>> +++ b/libocfs2/chain.c
>> @@ -31,7 +31,9 @@
>>  
>>  #include "ocfs2/byteorder.h"
>>  
>> -void ocfs2_swap_group_desc(struct ocfs2_group_desc *gd)
>> +void ocfs2_swap_group_desc(ocfs2_filesys *fs,
>> +			   struct ocfs2_group_desc *gd,
>> +			   int suballocator, int from_cpu)
> 
> 	In ocfs2_tools, we provide ocfs2_swap_xxx_{to,from}_cpu().  We
> do not pass an integer argument.  See ocfs2_swap_inode_{to,from}_cpu(),
> etc.
ok, I will change it.
> 	I want to make you get rid of the 'suballocator' argument from
> these functions, but I can't see how, as we don't have the inode.
As for suballocator, see my e-mail replied to [PATCH 06/22].

Regards,
Tao