[Ocfs2-tools-devel] [PATCH 06/22] libocfs2: Make ocfs2_init_group_desc aware of discontig group.
Tao Ma
tao.ma at oracle.com
Thu Apr 1 01:01:23 PDT 2010
Joel Becker wrote:
> On Thu, Apr 01, 2010 at 12:41:10PM +0800, Tao Ma wrote:
>> Pass a parameter named suballoc to ocfs2_init_group_desc
>> so that it can init bg_size properly.
>
> I hate passing this parameter around. I don't know how to make
> it better.
yeah, the only way is that we can add a new member in ocfs2_group_desc,
but that are only 2 reserved field(1 le32 and one le64), so I don't want
to waste them.
Another way is that we separate bg_chain to a __le8
- __le16 bg_chain;
+ __le8 bg_chain;
+ __le8 bg_flags;
But I also think it doesn't worth.
Regards,
Tao
More information about the Ocfs2-tools-devel
mailing list