[Ocfs2-tools-devel] [PATCH 0/9] Quota support for ocfs2 tools (version 3)

[Jan Kara]

On Thu 03-09-09 10:04:27, tristan.ye wrote:
> On Wed, 2009-09-02 at 14:54 -0700, Joel Becker wrote:
> > On Tue, Aug 11, 2009 at 02:26:03PM +0200, Jan Kara wrote:
> > >   here comes next version of my ocfs2 tools patches to implement full quota
> > > support. All the comments of the reviewers have been taken into account and
> > > also all the bugs found by Tristan should be fixed now (if this series is
> > > applied on top of the two patches I've sent earlier today). So I hope
> > > the series is now ready to be merged.
> > 
> > 	Looks like you've addressed the concerns, and Tristan had a good
> > report, so I've pushed these to ocfs2-tools.git.
> 
> Joel,
> 
> I remembered the most stable patches set is V4, jan's final patch
> series, see mail:
> [PATCH 0/11] Quota support for ocfs2-tools and a couple of fixes.
> 
> The final patches set includes 11 patches, and my good testing report
> was against that one..shouldn't you push this one to ocfs2-tools.git?
  Yes. Joel took the previous version. But he also included the two
additional patches (I've sent them separately previously) so the only
difference is the below chunk (I've just run git diff on my branch vs
current master):

diff --git a/fsck.ocfs2/pass5.c b/fsck.ocfs2/pass5.c
index ff3bf16..1f5ed82 100644
--- a/fsck.ocfs2/pass5.c
+++ b/fsck.ocfs2/pass5.c
@@ -201,7 +201,7 @@ static errcode_t o2fsck_check_data_blk(o2fsck_state *ost, int type,
 	struct ocfs2_global_disk_dqblk *ddquot;
 	ocfs2_cached_dquot *dquot;
 	uint32_t blocks = fs->qinfo[type].qi_info.dqi_blocks;
-	int valid;
+	int valid = 1;
 
 	ocfs2_set_bit(blk, qbmp[type]);
 	ret = o2fsck_read_blk(fs, type, buf, blk);

  Joel, would you please add this fix? Thanks. If you need a changelog,
you can put there:
  "Fix false warnings about corrupted quotas from fsck.ocfs2"
Feel free to add my Signed-off-by.

									Honza
-- 
Jan Kara <jack at suse.cz>
SUSE Labs, CR