[Ocfs2-tools-devel] [PATCH 2/2] fsck.ocfs2: update i_clusters in swap_clone.

[Joel Becker]

On Mon, Oct 12, 2009 at 09:22:26AM +0800, Tao Ma wrote:
> Joel Becker wrote:
> >On Sat, Oct 10, 2009 at 07:11:51PM -0700, Joel Becker wrote:
> >>On Sat, Oct 10, 2009 at 05:03:36PM +0800, Tao Ma wrote:
> >>>In new_clone, we allocate all the clusters disregard whether
> >>>there are holes. So we also need to update the i_clusters in
> >>>swap_clone to make the inode consistent.
> >>sob
> >
> >	Would be really neat if we could keep the holes, of course ;-)
> yeah, that is my next plan since my refcount need this also.
> But I just want to fix the bug first. :)

	Just so you know, I used the read/write solution because it was
fast an obviously correct.  I didn't want to waste time open-coding the
allocation, etc.  I figured we could revisit it, like you are doing.

Joel

-- 

"We will have to repent in this generation not merely for the
 vitriolic words and actions of the bad people, but for the 
 appalling silence of the good people."
	- Rev. Dr. Martin Luther King, Jr.

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127