[Ocfs2-tools-devel] [PATCH 2/6] Ocfs2-tools: Add utils header to o2info.

[Tristan]

Tao Ma wrote:
>
>
> Tristan wrote:
>> TaoMa wrote:
>>> Tristan Ye wrote:
>>>> Prototype definition of utils funcs for o2info.
>>>>
>>>> Signed-off-by: Tristan Ye <tristan.ye at oracle.com>
>>>> ---
>>>>  o2info/o2info_utils.h |   51 
>>>> +++++++++++++++++++++++++++++++++++++++++++++++++
>>>>  1 files changed, 51 insertions(+), 0 deletions(-)
>>>>  create mode 100644 o2info/o2info_utils.h
>>>>
>>>> diff --git a/o2info/o2info_utils.h b/o2info/o2info_utils.h
>>>> new file mode 100644
>>>> index 0000000..177c01a
>>>> --- /dev/null
>>>> +++ b/o2info/o2info_utils.h
>>>> @@ -0,0 +1,51 @@
>>>> +/* -*- mode: c; c-basic-offset: 8; -*-
>>>> + * vim: noexpandtab sw=8 ts=8 sts=0:
>>>> + *
>>>> + * o2info_utils.h
>>>> + *
>>>> + * Common utility function prototypes
>>>> + *
>>>> + * Copyright (C) 2008 Oracle.  All rights reserved.
>>>>   
>>> 2009 please.
>>>> + *
>>>> + * This program is free software; you can redistribute it and/or
>>>> + * modify it under the terms of the GNU General Public
>>>> + * License as published by the Free Software Foundation; either
>>>> + * version 2 of the License, or (at your option) any later version.
>>>> + * + * This program is distributed in the hope that it will be 
>>>> useful,
>>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>>>> + * General Public License for more details.
>>>> + * + * You should have received a copy of the GNU General Public
>>>> + * License along with this program; if not, write to the
>>>> + * Free Software Foundation, Inc., 59 Temple Place - Suite 330,
>>>> + * Boston, MA 021110-1307, USA.
>>>>   
>>> The license information has changed. Please refer to libocfs2/xattr.c.
>> Thanks for correcting this.
>>>> + *
>>>> + */
>>>> +
>>>> +#ifndef __O2INFO_UTILS_H__
>>>> +#define __O2INFO_UTILS_H__
>>>> +
>>>> +#include "o2info.h"
>>>>   
>>> I haven't seen this file by now.
>> This file comes with patch 3/6.
> yes, I know, but if we apply this patch, the build will be broken.
> Please note that when we separate a large patch into several small 
> ones, we need to make sure at any stage we should build it 
> successfully. Otherwise a git bisect maybe fail to build.

Got it, I'll exchange the place of 3rd and 2nd patches, thank you.

>
> Regards,
> Tao