[Ocfs2-tools-devel] [PATCH 1/9] libocfs2: Make the feature names the same as the feature flags

Joel Becker Joel.Becker at oracle.com
Fri May 8 18:46:25 PDT 2009


On Fri, May 08, 2009 at 01:55:50PM -0700, Mark Fasheh wrote:
> On Wed, May 06, 2009 at 06:48:37PM -0700, Sunil Mushran wrote:
> > tunefs and debugfs were pretty printing the features in studly caps.
> > The patch makes these tools print them in the same format as what
> > mkfs/tunefs accept as feature flags.
> > 
> > Signed-off-by: Sunil Mushran <sunil.mushran at oracle.com>
> 
> I guess it's pointless to #define those strings yet, eh?

	Sunil and I discussed merging the two structures, but that would
require flagging which features could be set in --fs-features and which
were internal, etc.  Definitely doable, probably the right thing, but
not worth holding up this change.

Joel

-- 

"The opposite of a correct statement is a false statement. The
 opposite of a profound truth may well be another profound truth."
         - Niels Bohr 

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127



More information about the Ocfs2-tools-devel mailing list