[Ocfs2-tools-devel] [PATCH 11/13] fsck.ocfs2: Pre-fill the I/O cache with metadata.

Sunil Mushran sunil.mushran at oracle.com
Fri Jun 19 15:33:07 PDT 2009


Ahh yes... we only want it for the inode/extent sub allocators.

Signed-off-by: Sunil Mushran <sunil.mushran at oracle.com>

Joel Becker wrote:
> On Fri, Jun 19, 2009 at 03:19:16PM -0700, Sunil Mushran wrote:
>   
>>> @@ -889,7 +902,7 @@ static errcode_t verify_bitmap_descs(o2fsck_state *ost,
>>> 		ocfs2_bitmap_set(allowed, blkno, NULL);
>>> 	}
>>> -	ret = verify_chain_alloc(ost, di, buf1, buf2, allowed, forbidden);
>>> +	ret = verify_chain_alloc(ost, di, buf1, buf2, NULL, allowed, forbidden);
>>>       
>> Isn't this verify_chain_alloc() run first()? Any reason why we
>> are not passing the pre_cache_buf here too.
>>     
>
> 	verify_bitmap_descs() is for the global chain allocator.  We'd
> be pre-caching the 256MB of data clusters :-)
>
> Joel
>
>   




More information about the Ocfs2-tools-devel mailing list