[Ocfs2-tools-devel] [PATCH 02/10] Ocfs2-tools: Redefine corrupt handlers for corrupt codes.

[tristan.ye]

On Fri, 2009-06-05 at 15:11 -0700, Joel Becker wrote:
> On Fri, Jun 05, 2009 at 03:45:35PM +0800, Tristan Ye wrote:
> > Here we redefine the corrupt handler for each existed corrupt code
> > associated with fsck.ocfs2, we still use the same corrupt_* func
> > family since the new corrupt codes is a subset of former ones to
> > some extent.
> 
> 	This is all fine except for one thing.
> 
> > diff --git a/fswreck/include/corrupt.h b/fswreck/include/corrupt.h
> > index 103ea43..36371ac 100644
> > --- a/fswreck/include/corrupt.h
> > +++ b/fswreck/include/corrupt.h
> > @@ -25,12 +25,17 @@
> >  #ifndef __CORRUPT_H
> >  #define __CORRUPT_H
> >  
> > +#include "fsck_type.h"
> > +
> 
> 	There's no need to add fsck_type.h to every other .h.  It's
> already in main.h.  Just move it above corrupt.h in main.h.  While
> you're there, can you change the fswreck internal includes from
> '#include <corrupt.h>' to '#include "corrupt.h"'?  They'll never be in
> the system include directories :-)

Thank you for pointing these out:-)



> 
> Joel
>