[Ocfs2-tools-devel] [PATCH 0/3] A couple fswreck patches

Tao Ma tao.ma at oracle.com
Wed Jun 3 19:51:19 PDT 2009


Hi Joel,
	all the 3 patches look good to me.

Regards,
Tao

Joel Becker wrote:
> Here are three patches to fswreck.  The first patch builds fswreck as an
> UNINST_PROGRAM.  There is never a reason it should be installed, but
> there is also no reason us developers should have to type "make -C
> fswreck" just to use it.
> 
> The second patch is a fix for the DIR_PARENT_DUP corruption.
> fswreck assumes that freshly created filesystems don't have inline
> directories.  That's no longer true, so DIR_PARENT_DUP explodes.  I
> changed it to use ocfs2_link().  There are more places that fswreck
> could use ocfs2_link() to avoid the inline-vs-no-inline problem, but
> I didn't spend time on that now.  It has been added to the tools task
> list.
> 
> The third patch implements a new corruption.  It creates two inodes
> that both point to the same extent.  This tests fsck's detection and
> (eventual) repair of that problem.
> 
> Joel
> 
> 
> 
> _______________________________________________
> Ocfs2-tools-devel mailing list
> Ocfs2-tools-devel at oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-tools-devel



More information about the Ocfs2-tools-devel mailing list