[Ocfs2-tools-devel] [PATCH 1/2] fsck.ocfs2: Print bold warning message when run with -F

[Joel Becker]

On Fri, Jul 24, 2009 at 11:01:35AM -0700, Sunil Mushran wrote:
> Joel Becker wrote:
> >	We need a better term than "using this filesystem".  Remember,
> >the folks that used -F thought "using" meant software was running.  They
> >thought a mounted filesystem with no open files was "unused".  Perhaps
> >something like "ABSOLUTELY SURE THAT NO NODE HAS THIS FILESYSTEM MOUNTED
> >OR IS OTHERWISE ACCESSING IT".
> 
> Nod. I added the mounted part in the man page. I'll add it here too.
> 
> >	We also don't seem to check is_mounted in fsck.  Shouldn't we?
> 
> 
> Yes. We should. I'll add that too.

	-F should allow mounted filesystems too, with the same warning.
I think that's how extN does it.  Also, we probably want to warn but not
prompt when -n is specified.

Joel

-- 

"Under capitalism, man exploits man.  Under Communism, it's just 
   the opposite."
				 - John Kenneth Galbraith

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127