[Ocfs2-tools-devel] [PATCH] tunefs.ocfs2: Check the bitmap with the correct cluster count.

[Joel Becker]

On Thu, Jul 23, 2009 at 12:42:26PM -0700, Sunil Mushran wrote:
> Signed-off-by: Sunil Mushran <sunil.mushran at oracle.com>
> 
> This patch is good... but I do have a related point.
> 
> Say we do:
> $ tunefs.ocfs2 -U -N 5 -vvv /dev/sdaf5
> 
> In this case, we will lock the domain using the original uuid,
> change the uuid and do the remaining ops. Theoretically, the
> user could do a series of ops that could widen the hole.
> 
> One solution could be to force uuid reset to be the last op.
> 
> Thoughts?

	Valid point.  We could also special case it to tear down and
rebuild the locking.  Moving it to the end is easier ;-)  At the end of
ocfs2ne.c:parse_options() we could call a function that checks for
reset_uuid in the run list and moves it to the end.  That would probably
be the cleanest hack.

Joel

-- 

"One of the symptoms of an approaching nervous breakdown is the
 belief that one's work is terribly important."
         - Bertrand Russell 

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127