[Ocfs2-tools-devel] [PATCH 13/18] tunefs.ocfs2: Display progress while setting the label.

Mark Fasheh mfasheh at suse.com
Wed Jan 14 14:54:23 PST 2009


Signed-off-by: Mark Fasheh <mfasheh at suse.com>

On Mon, Jan 05, 2009 at 06:33:49PM -0800, Joel Becker wrote:
> Simple progress display for the label setting operation.
> 
> Signed-off-by: Joel Becker <joel.becker at oracle.com>
> ---
>  tunefs.ocfs2/op_set_label.c |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
> 
> diff --git a/tunefs.ocfs2/op_set_label.c b/tunefs.ocfs2/op_set_label.c
> index c0a62a8..cb30e6d 100644
> --- a/tunefs.ocfs2/op_set_label.c
> +++ b/tunefs.ocfs2/op_set_label.c
> @@ -31,6 +31,7 @@ static errcode_t update_volume_label(ocfs2_filesys *fs, const char *label)
>  {
>  	errcode_t err;
>  	int len = strlen(label) + 1;  /* Compare the NUL too */
> +	struct tools_progress *prog;
>  
>  	if (len > OCFS2_MAX_VOL_LABEL_LEN)
>  		len = OCFS2_MAX_VOL_LABEL_LEN;
> @@ -49,6 +50,13 @@ static errcode_t update_volume_label(ocfs2_filesys *fs, const char *label)
>  			    OCFS2_MAX_VOL_LABEL_LEN, label))
>  		return 0;
>  
> +	prog = tools_progress_start("Setting label", "label", 1);
> +	if (!prog) {
> +		err = TUNEFS_ET_NO_MEMORY;
> +		tcom_err(err, "while initializing the progress display");
> +		return err;
> +	}
> +
>  	memset(OCFS2_RAW_SB(fs->fs_super)->s_label, 0,
>  	       OCFS2_MAX_VOL_LABEL_LEN);
>  	strncpy((char *)OCFS2_RAW_SB(fs->fs_super)->s_label, label,
> @@ -58,6 +66,9 @@ static errcode_t update_volume_label(ocfs2_filesys *fs, const char *label)
>  	err = ocfs2_write_super(fs);
>  	tunefs_unblock_signals();
>  
> +	tools_progress_step(prog, 1);
> +	tools_progress_stop(prog);
> +
>  	return err;
>  }
>  
> -- 
> 1.5.6.5
--
Mark Fasheh



More information about the Ocfs2-tools-devel mailing list