[Ocfs2-tools-devel] [RFC] [PATCH] ocfs2-tools: mark 'datavolume' in OCFS2 1.4 as obsoleted in documents

[Coly Li]

Sunil Mushran Wrote:
> We no longer maintain this faq in ocfs2-tools. Instead we update
> the one on oss.oracle.com. There the older faq has been moved
> under ocfs2 1.2 docs.
> 
> I am not sure we need to document this change in behavior. As in,
> the complicated explanation has no real value to end users. We should
> just let this mount option fade away into the sunset. No glorious send
> off. :)
> 
> All we have to do is ensure that the oracle db users are setting
> the init.ora parameter filesystemio_options appropriately. The ocfs2
> 1.4 guide explains that bit.
> 
Thanks for the review ;)
Customer reported a bug (novall bugzilla bnc#450972) because they saw 'datavolume' was supported in
mount.ocfs2.8 and this option could not be used in real system.

Announcing datavolume option supported in manual (especially in upstream ocfs2-tools, not the
package in Enterprise Linux) will introduce chance to make end users misunderstand that 'datavolume'
is still functional (which is not true). That's why I send out this patch.

I agree to keep this option in SLE11, but I do suggest to remove it from SLE12. If we notice end
users that 'datavolume' option is obsoleted, there might be no more similar bug report in SLE12.
IMHO, it's hard for me to find a reason to keep the dummy 'datavolume' code in SLE12.



> Coly Li wrote:
>> In OCFS2 1.4, mount option "datavolume" is not supported in upstream
>> any more. In enterprise kernel
>> like SLE11 HASI (SuSE Linux Enterprise 11 High Availability Storage
>> Infrastructure) this option is
>> still accepted for compatibility reason, but do nothing indeed.
>>
>> This patch adds explaining of 'datavolume' option support in OCFS2 1.4
>> of SLE11 HASI kernel. On
>> kernel side, datavolume is still accepted, but a printk message will
>> info users that the option is
>> deprecated now.
>>
>> Any feedback is welcome. Thanks for review.
>>
>> Signed-off-by: Coly Li <coly.li at suse.de>
>> ---
>>  documentation/ocfs2_faq.txt  |   10 +++++++---
>>  mount.ocfs2/mount.ocfs2.8.in |    4 +++-
>>  2 files changed, 10 insertions(+), 4 deletions(-)
>>
>> diff --git a/documentation/ocfs2_faq.txt b/documentation/ocfs2_faq.txt
[snip]

-- 
Coly Li
SuSE Labs