[Ocfs2-tools-devel] [PATCH 04/12] fsck.ocfs2: Add checking of directory trailers.

[Joel Becker]

On Tue, Jan 06, 2009 at 05:57:07PM -0800, Sunil Mushran wrote:
> One typo. Else looks good.
>
<snip>
> +
>> +	if ((trailer->db_compat_rec_len !=
>> +	     sizeof(struct ocfs2_dir_block_trailer)) &&
>> +	    prompt(ost, PY, PR_DIR_TRAILER_REC_LEN,
>> +		   "Directory block trailer for logical block %"PRIu64" "
>> +		   "physcal block %"PRIu64" in directory inode %"PRIu64" "
>> +		   "has an invalid rec_len.  Fix it?",
>> +		   dbe->e_blkcount, dbe->e_blkno, dbe->e_ino)) {
>> +		trailer->db_compat_rec_len = 0;
>> +		*flags |= OCFS2_DIRENT_CHANGED;
>> +	}
>>   
>
> Shouldn't it be:
> +		trailer->db_compat_rec_len = sizeof(struct ocfs2_dir_block_trailer);

	Eek!

Joel

-- 

"This is the end, beautiful friend.
 This is the end, my only friend the end
 Of our elaborate plans, the end
 Of everything that stands, the end
 No safety or surprise, the end
 I'll never look into your eyes again."

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127