[Ocfs2-tools-devel] [PATCH] tunefs.ocfs2: Init eb in dirdata_iterate for metaecc feature.

[Joel Becker]

Sob.  How'd I miss that in testing?

Joel

On Tue, Feb 10, 2009 at 08:22:15AM +0800, Tao Ma wrote:
> ‘eb’ is used uninitialized in dirdata_iterate. So initialize it.
> 
> Signed-off-by: Tao Ma <tao.ma at oracle.com>
> ---
>  tunefs.ocfs2/feature_metaecc.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/tunefs.ocfs2/feature_metaecc.c b/tunefs.ocfs2/feature_metaecc.c
> index fcfc1bf..0d88de7 100644
> --- a/tunefs.ocfs2/feature_metaecc.c
> +++ b/tunefs.ocfs2/feature_metaecc.c
> @@ -966,6 +966,7 @@ static int dirdata_iterate(ocfs2_filesys *fs, struct ocfs2_extent_rec *rec,
>  	if (tree_depth) {
>  		verbosef(VL_DEBUG, "Reading extent block at %"PRIu64"\n",
>  			 rec->e_blkno);
> +		eb = (struct ocfs2_extent_block *)buf;
>  		ret = ocfs2_read_extent_block(fs, rec->e_blkno, (char *)eb);
>  		if (ret)
>  			goto out;
> -- 
> 1.5.4.GIT
> 

-- 

Life's Little Instruction Book #313

	"Never underestimate the power of love."

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127