[Ocfs2-tools-devel] [PATCH]ocfs2console: Restore previous warning filter aftre importing gtk in ocfs2console

[Joel Becker]

On Sat, Feb 07, 2009 at 10:46:14PM +0800, Hu.Ziming wrote:
> Setting the filter of warnings module will change the segmental fault of
> program ocfs2console to a exception when the DISPLAY is set incorrectly. But
> some unwanted warning message will be printed due to this solution. Reseting
> the warning filter after importing gtk module will solve this problem, but
> some filter in the default runtime environment will also be purged, which will
> leads to some other problems.
> 
> The warning filter is saved as a list in the runtime environment. The new
> patch will just pop the new added 'error' filter out of the list instead of
> reset the list.

	Huh, who is adding these filters?  But assuming you're right
(otherwise, you wouldn't have cared), this looks like the right thing to
do.

Joel


-- 

"But then she looks me in the eye
 And says, 'We're going to last forever,'
 And man you know I can't begin to doubt it.
 Cause it just feels so good and so free and so right,
 I know we ain't never going to change our minds about it, Hey!
 Here comes my girl."

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127