[Ocfs2-tools-devel] [PATCH 12/44] ocfs2: Decrement refcount when truncating refcounted extents.

Joel Becker Joel.Becker at oracle.com
Thu Dec 31 12:27:46 PST 2009


On Thu, Dec 31, 2009 at 03:47:22PM +0800, Tao Ma wrote:
> >	I know we don't use refcount records in the xattr tree right
> >now, but couldn't we some day?  What's the harm in adding ino here?  No
> >extent will have REFCOUNTED_FL anyway.
> well, now we don't suppot refcount in xattr tree and I have added an
> "assert(ino)," in ocfs2_truncate_clusters.
> So in case we get a refcounted xattr tree, it will woe and we can
> get that the disk is somehow corrupted.
> Does it make sense?
> So why not change this after we add support for refcounted xattr tree?

	Whatever is easiest.  I wondered if leaving it generic would be
compatible whenever we added kernel support.  But if not, there's no
point.

Joel

-- 

"I don't know anything about music. In my line you don't have
 to."
        - Elvis Presley

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127



More information about the Ocfs2-tools-devel mailing list