[Ocfs2-tools-devel] [PATCH 16/44] libocfs2: Add the 'refcount' feature to the feature definitions.

Tao Ma tao.ma at oracle.com
Wed Dec 30 23:39:54 PST 2009



Joel Becker wrote:
> On Mon, Dec 28, 2009 at 05:01:01PM +0800, Tao Ma wrote:
>   
>> @@ -210,6 +216,10 @@ static struct feature_name ocfs2_feature_names[] = {
>>  		.fn_flag = {0, 0, OCFS2_FEATURE_RO_COMPAT_GRPQUOTA},
>>  	},
>>  	{
>> +		.fn_name = "RefcountTree",
>> +		.fn_flag = {0, OCFS2_FEATURE_INCOMPAT_REFCOUNT_TREE, 0},
>> +	},
>> +	{
>>     
>
> 	Names should match the feature that selects them.  So this
> should be 'refcount'.  Basically, when debugfs, tunefs, or o2info
> displays a feature, we want the user to be able to cut and paste it back
> to mkfs or tunefs.
>   
yeah, got it. I will modify it and add my sob also.

Regards,
Tao



More information about the Ocfs2-tools-devel mailing list