[Ocfs2-tools-devel] [PATCH 1/2] merge ocfs2_fs.h from upstream, v2
Coly Li
coly.li at suse.de
Thu Dec 10 21:56:22 PST 2009
On 2009年12月11日 05:35, Joel Becker Wrote:
> On Wed, Dec 09, 2009 at 10:14:17PM +0800, Coly Li wrote:
>> Hmm, since we don't always make include/ocfs2-kernel/ocfs2_fs.h identical to fs/ocfs2/ocfs2_fs.h, is it necessary for us
>> to keep the kernel space function declaration in include/ocfs2-kernel/ocfs2_fs.h ?
>>
>> Maybe we should remove all code within #ifdef __KERNEL__ ?
>
> No, we *want* userspace and kernelspace to be identical. That
> is our goal. We run into problems when a feature is done in the kernel
> but not yet in the tools. We need to do a better job of having both
> ready at the same time.
>
Make sense.
If the user space support is not done, the corresponded kernel part routines should not be included in the header neither.
Thanks :-)
--
Coly Li
SuSE Labs
More information about the Ocfs2-tools-devel
mailing list