[Ocfs2-tools-devel] [PATCH 1/2] merge ocfs2_fs.h from upstream, v2

[Coly Li]

On 2009年12月08日 20:33, Joel Becker Wrote:
> On Tue, Dec 08, 2009 at 04:28:51PM +0800, Coly Li wrote:
>> - The kernel part function is not necessary in ocfs2_fs.h ?
>> - Should we merge our user space functions announcement into ocfs2_fs.h, or announce them somewhere else, or merged in
>> ocfs2_fs.h ?
> 
> 	Both kernel and userspace calculations belong in ocfs2_fs.h
> 	Here's the thing.  When tools and the kernel both support the
> same feature set, ocfs2_fs.h must be identical between them.  When they
> do not support the same feature set (like now, when the kernel has
> reflink and userspace does not), either we leave out everything about
> the feature, or we add the definitions but leave the feature out of SUPP
> (as your patch does).
> 	If we add the definitions, we have to be careful.  When quota
> was added, it changed OCFS2_LAST_GLOBAL_SYSTEM_INODE.  In userspace,
> adding the quota definitions before quota support existed in mkfs would
> have broken things.
> 

Hmm, since we don't always make include/ocfs2-kernel/ocfs2_fs.h identical to fs/ocfs2/ocfs2_fs.h, is it necessary for us
to keep the kernel space function declaration in include/ocfs2-kernel/ocfs2_fs.h ?

Maybe we should remove all code within #ifdef __KERNEL__ ?

-- 
Coly Li
SuSE Labs