[Ocfs2-tools-devel] [PATCH 1/2] merge ocfs2_fs.h from upstream, v2

[Coly Li]

On 2009年12月08日 14:29, Tao Ma Wrote:
> 
> 
> Coly Li wrote:
>> This patch merges upstream fs/ocfs2/ocfs2_fs.h header file into
>> include/ocfs2-kernel/ocfs2_fs.h, while untouching the
>> SUPP definition.
>>
>> The merged header is helpful to support new features like indexed-dir
>> or reflink in user space tools.
> actually I am working on implementing user space support for reflink and
>  disk layout for reflink is one patch in a large series, but I have no
> objection to include it in your patch here. I can remove my patch from
> the patch set.
>>
>> Signed-off-by: Coly Li <coly.li at suse.de>
>> Cc: Joel Becker <joel.becker at oracle.com>
>> ---
>>  include/ocfs2-kernel/ocfs2_fs.h |  241
>> +++++++++++++++++++++++++++++++++++++--
>>  1 files changed, 229 insertions(+), 12 deletions(-)
>>
[snip]

> Since you added the kernel part, could you please also add the functions
> for the userspace part?
> I mean function
> ocfs2_dx_entries_per_root(int blocksize).
> Or you have a plan to add it together with your implementation of dx_dir
> for userspace? I want to make sure because you also add the function for
> refcount block below, if you don't want to add them(functions with
> blocksize as the parameter), I need to preserve it in my patch.

My original idea was just synchronizing the kernel header. But now I think maybe,
- The kernel part function is not necessary in ocfs2_fs.h ?
- Should we merge our user space functions announcement into ocfs2_fs.h, or announce them somewhere else, or merged in
ocfs2_fs.h ?

Thanks.
-- 
Coly Li
SuSE Labs