[Ocfs2-tools-devel] [PATCH 0/11] Quota support for ocfs2-tools and a couple of fixes

[tristan.ye]

On Wed, 2009-08-26 at 15:17 +0200, Jan Kara wrote:
> Hi,
> 
>   here comes probably the final version of quota support for ocfs2-tools.  I've
> heard no further comments from reviewers and fixed one or two minor bugs
> Tristan has found during his testing. So Sunil, can you merge the patches to
> ocfs2-tools tree? Thanks everybody for testing and useful comments.

Jan,

This v4 patches set for quota support on ocfs2-tools was awesome! all
tests in my current quota-tools-test passed, and all open bugs get
fixed!

One concern is something about inline-data and xattr.

1) Assume we have inline-data and usrquota,grpquota all enabled in a
ocfs2 volume, when disabling the inline-data feature, all inlined files
are going to be extented to clusters, and it begins to consume space, I
think such space consumption caused by expansion from inline to extents
deserves our re-calculation for quota usage. I knew disabling 'sparse'
feature by tunefs.ocfs2 was doing a great job on this part...so we do
want disabling 'inline-data' also do the same thing.


2) For the xattr, I'm not quite familiar with your current strategy on
this. we maybe want to make following things clear.

   1. Xattr entries attached to a given file also consume space on a
target volume, so should such space consumption be taken account into
our quota calculation?

   2. Disabling xattr feature removes all ea entries from host file,
right? and such space release also should cause our recalculation on
quota usage, right?


Issue 1) should be a bug I guess, while issue 2 is something more like a
problem of strategy which deserves our disscussion.


Regards,
Tristan.


> 
> 									Honza