[Ocfs2-tools-devel] [PATCH 6/6] libocfs2: add set and get xattr operations

[Joel Becker]

On Tue, Aug 18, 2009 at 11:07:00AM +0800, Tiger Yang wrote:
> Joel Becker wrote:
> >>	Again, why aren't the public functions named 'ocfs2_xattr_get()'
> >>and 'ocfs2_xattr_set()'?
> 
> I presume "generic" is more public. Because the parameter "name" is a
> full name string, like "user.name", in this function, we split the full
> name to name_index and xattr name.
> Anyway, I can exchange the function name if they are not appropriate.

	What would you like to write as an application developer?  I,
personally, would just like to say "ocfs2_xattr_get()".  I don't want to
have to type "generic" :-)

> >>+errcode_t ocfs2_xattr_name_iterate(ocfs2_cached_inode *ci,
> >>+				   int (*func)(ocfs2_cached_inode *ci,
> >>+						const char *name,
> >>+						void *priv_data),
> >>+				   void *priv_data)
> >>+{
> >>+	errcode_t ret = 0;
> >>+	return ret;
> >>+}
> >
> >	And will you be implementing this?
> 
> No, I will remove this. I think this function is not necessary. I
> add listing xattr function in debugfs, and our set/get operations
> will search all xattr entry.

	Ok, as an application developer, how do I find out what xattrs
are on an inode?  Say I'm writing fswreck.  How do I discover this?

Joel

-- 

"When ideas fail, words come in very handy." 
         - Goethe

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127