[Ocfs2-tools-devel] [PATCH 6/9] mkfs.ocfs2: Add FEATURE_COMPAT_JBD2_SB.

[Tao Ma]

Joel Becker wrote:
> On Tue, Sep 09, 2008 at 05:57:13PM -0700, Joel Becker wrote:
>> All filesystems that support FEATURE_COMPAT_JBD2_SB can handle journal
>> superblock features.  We use this feature to prevent older fsck/tunefs
>> from loading journal features they don't understand (since they never
>> checked).  The code at this point will check for unknown features, and
>> it doesn't know any.  Thus it can safely fsck/tune JBD2_SB filesystems
>> it creates.
> 
> 	Turns out there is a bug in mkfs.ocfs2 - it doesn't handle
> compat features right.  Here's the fix, which I'll put at the front of
> the series:
> 
> mkfs.ocfs2: Fix a bug in COMPAT_BACKUP_SUPER handling.
> 
> The backup superblock handling tried to clear the backup super bit with
> 
>     opt_compat &= !OCFS2_FEATURE_COMPAT_BACKUP_SUPER
> 
> However, ! is not the same as ~.  Fix it.
> 
> Signed-off-by: Joel Becker <joel.becker at oracle.com>
Signed-off-by: Tao Ma <tao.ma at oracle.com>