[Ocfs2-tools-devel] [PATCH 5/5] ocfs2-tools: add xattr support in mkfs.ocfs2

[Coly Li]

Tiger Yang Wrote:
> Coly Li wrote:
>>> +        "xattr",
>>> +        {0, OCFS2_FEATURE_INCOMPAT_XATTR, 0},
>>> +        {0, OCFS2_FEATURE_INCOMPAT_XATTR, 0},
>>> +    },
>>> +    {
>>>          NULL,
>>>          {0, 0, 0},
>>>          {0, 0, 0}
>>> @@ -169,6 +175,10 @@ static struct feature_name ocfs2_feature_names[]
>>> = {
>>>          .fn_flag = {OCFS2_FEATURE_COMPAT_JBD2_SB, 0, 0},
>>>      },
>>>      {
>>> +        .fn_name = "Xattr",
>> I see "xattr" and "Xattr" in this apatch, should them be different ?
> 
> Yes. They are different. "xattr" is the feature name we support in
> mkfs/tunefs. For example if we want to enable xattr support on a new
> volume, we use mkfs.ocfs2 --fs-features=xattr -C xxx -b xx /dev/sdax.
> 
> In debugfs.ocfs2, you can see the features this volume support by
> 'stats'. Such as
> Feature Compat: BackupSuper
> Feature Incompat: Sparse Xattr
> 
aha, I see ;-) Thanks for your explaining :-)

-- 
Coly Li
SuSE PRC Labs