[Ocfs2-tools-devel] [PATCH 04/39] o2cb: change the heartbeat API

Mark Fasheh mfasheh at suse.com
Fri May 16 17:01:48 PDT 2008


On Fri, Mar 14, 2008 at 04:52:27PM -0700, Joel Becker wrote:
> - o2cb_[start|stop]_heartbeat_region() have been replaced by
>   o2cb_begin_group_join(), o2cb_complete_group_join(), and
>   o2cb_group_leave().  These functions now take a service name to describe
>   who is accessing the region.  The service is usually the mountpoint,
>   but tools will use their program name.
> - Failed mounts pass an error to o2cb_complete_group_join(), which will
>   handle stopping any started region.  Thus, failed mounts should not
>   call o2cb_group_leave() like they used to call
>   o2cb_stop_heartbeat_region().
> - mount.ocfs2 called ocfs2_start_heartbeat().  Change it to call
>   o2cb_begin_group_join() and o2cb_complete_group_join().
> - umount.ocfs2 is changed to call o2cb_group_leave() after umount(2).
> - All of the other tools never called ocfs2_hb_ctl.  They call
>   ocfs2_initalize_dlm() and ocfs2_shutdown_dlm().  These functions have
>   been changed to call the new o2cb_group_* API.  This works for all
>   tools.
> - ocfs2_hb_ctl is now only useful for querying the state and
>   starting/stopping regions by hand.
> 
> Signed-off-by: Joel Becker <joel.becker at oracle.com>

Signed-off-by: Mark Fasheh <mfasheh at suse.com>




More information about the Ocfs2-tools-devel mailing list