[Ocfs2-tools-devel] [PATCH] libocfs2: ocfs2_write_super() should update all superblocks

[Tao Ma]

Joel Becker wrote:
> On Wed, Jul 09, 2008 at 04:30:07PM +0800, Tao Ma wrote:
>> Looks great. Just one concern.
>>
>>> @@ -1552,38 +1539,14 @@ skip_cluster_start:
>>>  		block_signals(SIG_BLOCK);
>>>  		ret = ocfs2_write_super(fs);
>> Here, you write the backups twice if the user's option is add  
>> backup-support(since we have already written once in  
>> update_backup_super). And the old solution will remove backup flag if  
>> the backup update fails(see below), but now I am not sure whether it is  
>> appropriate.
> 
> 	Yeah, I decided that writing the backups twice is fine,
> certainly better than the complexity of trying to avoid it.
> 	Sunil and I discussed removing the flag.  I think we want to
> keep it - it's a hint to any following program that it should try to
> recreate them.  Otherwise we've just disabled the feature.  Plus, if the
> backups failed, the old backups are still good, just out of date.  Which
> is better than having no backups at all.
OK, agree.
Signed-off-by: Tao Ma <tao.ma at oracle.com>