[Ocfs2-tools-devel] [PATCH] A new ocfs2 configure file vertify tool.

[shawn]

Hi Sunil,
Thank you for your comments!
I fixed some codes and  resend this tool to the mail list.

Please check it again.

Regards,
Xiaowei

On Tue, 2008-01-22 at 16:53 -0800, Sunil Mushran wrote:
> Much improved.
> 
> 1. Blindly creating /tmp/ocfs2/... is not good. We may overwrite
> some useful stuff. Use mktemp to create a temp dir under /tmp.
> 
yes,that is a problem ,but what I need is a directory, mktemp can only
create a temp file for use,so I used the timestamp as the subdir in this
directory, and after complete delete this subdir immediately.So I think
that won't be a problem.


> 2. If I execute without any parameters, it starts running. Better
> if we show help instead. Expect --fullscan and --quickscan for
> the two modes.
Done, to use this tool,you must specify the configure file location
now,eg:
./o2cb_verify.sh /etc/ocfs2/cluster.conf

> 
> 3. The output needs to be save-able. As in, provide users with an
> option to save the output to a output file. Redirection won't work
> as we show progress and also use colors. -o possibly.
Yes, it is already save-able,use the -o option follow the specified file
name.

> 
> 4. Lastly, I ran this on ca-test96. It then proceeded to ssh to
> its private ip and claimed that the cluster.conf needed sync.
> I am puzzled. Don't we use the cluster.conf of the node we are
> running the command on as the "correct" one? If so, then the
> compare logic is flawed. Apart from the fact that we should
> recognize that we are on that node.
This really a problem,I fixed this bug.
Now,it won't ssh to itself and will mark itself with green "THIS NODE".

> 
> Overall, it looks good. Address these final bits and then we can
> ask others for comments.
> 
> Sunil
> 
> shawn wrote:
> > It has been nearly one month since I send out the newest version of this
> > tool.
> > Can I ask if this tool is taken into account?Or any other modification
> > needed?
> > Latest version:
> > http://oss.oracle.com/pipermail/ocfs2-tools-devel/2007-December/000512.html
> >
> > Thanks for advance!
> >
> > Xiaowei
> >
> >
> > _______________________________________________
> > Ocfs2-tools-devel mailing list
> > Ocfs2-tools-devel at oss.oracle.com
> > http://oss.oracle.com/mailman/listinfo/ocfs2-tools-devel
> >   
>