[Ocfs2-tools-devel] [PATCH 1/1] fsck.ocfs2: Fail to do normal block check when the file has tree depth > 1. take 2

Mark Fasheh mark.fasheh at oracle.com
Wed Jan 16 14:03:24 PST 2008


On Wed, Jan 16, 2008 at 11:18:41PM +0800, tao.ma wrote:
> In 2nd bug fix, it should be "!ret". I removed "!" for the test, but forget to add
> it back. Sorry for that. So resend the patch.
> 
> For a file which has l_tree_depth > 1, fsck.ocfs2 fail to check it. And even
> worse, it writes the wrong value to i_last_eb_blk and return no error. So next
> time when the volume is mounted and this file is written, fs will be made
> read-only. This is caused by 2 minor bugs.
> 
> 1. ocfs2_extent_iterate_inode intializes the walk-through extent block buffer
>    pointer to a wrong value.
> 2. We write back the wrong i_last_eb_blk regardless of the return value.
> 
> So fix them.
> 
> Signed-off-by: Tao Ma <tao.ma at oracle.com>
Signed-off-by: Mark Fasheh <mark.fasheh at oracle.com>

--
Mark Fasheh
Principal Software Developer, Oracle
mark.fasheh at oracle.com



More information about the Ocfs2-tools-devel mailing list