[Ocfs2-tools-devel] [PATCH 0/4] includes: Create a public include directory

Mark Fasheh mark.fasheh at oracle.com
Thu Jan 10 16:31:45 PST 2008


On Tue, Jan 08, 2008 at 11:40:38AM -0800, Joel Becker wrote:
> 
> Each library in ocfs2-tools has its own include subdirectory.  This makes
> it hard to find the header you're looking for and creates some header
> dependency headaches.  Each tool in ocfs2-tools has to include the
> headers in a local fashion, while external software has to use a standard
> fashion.
> 
> With the new layout, headers are included the same for ocfs2-tools and
> external software both.  Looking for public headers is entirely in the
> $(TOPDIR)/include/ directory.  Headers that are local to a library are
> next to the sources they match.
> 
> The changes clean up the Makefiles with neutral impact to source files.
> 
> There are four patches in the series.
> 1. Common headers from the kernel
> 2. libo2dlm headers
> 3. libo2cb headers
> 4. libocfs2 headers
> 
> The patches are in git format, as so much of this is moving files.
> This should make it clear the small and repeatable changes made to
> Makefiles and source files to clean them up.
> 
> Comments welcome, from layout to change ordering to whether this is
> worth doing in the first place.

That all looks good to me, so global sign-off!

Signed-off-by: Mark Fasheh <mark.fasheh at oracle.com>
	--Mark

--
Mark Fasheh
Principal Software Developer, Oracle
mark.fasheh at oracle.com



More information about the Ocfs2-tools-devel mailing list