[Ocfs2-tools-devel] [PATCH 1/4] includes: Rework the core filesystem includes.

[Joel Becker]

On Mon, Jan 07, 2008 at 05:30:05PM -0800, Mark Fasheh wrote:
> On Mon, Jan 07, 2008 at 05:19:31PM -0800, Joel Becker wrote:
> >  include/ocfs2fs/Makefile                  |   14 +
> >  include/ocfs2fs/kernel-list.h             |  116 ++++
> >  include/ocfs2fs/ocfs1_fs_compat.h         |  109 ++++
> >  include/ocfs2fs/ocfs2_fs.h                |  823 +++++++++++++++++++++++++++++
> >  include/ocfs2fs/sparse_endian_types.h     |   13 +
> 
> Maybe we should just call these include/linux/ or include/kernel/?
> 
> Also, ocfs2_lockid.h (a kernel header which is copied verbatim) should go in
> here too.
> 
> That way we can easily find all our "got it from kernel" header files.

	That's a pretty damned good idea.  I left kernel-rbtree.h in
include/ocfs2/ (later patch) because it was only used internally by
libocfs2 bits, but I felt unsure of that placement.  With include/linux
as our design, it clearly goes there as well.

Joel

-- 

"Three o'clock is always too late or too early for anything you
 want to do."
        - Jean-Paul Sartre

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127