[Ocfs2-tools-devel] [PATCH 3/6] Abstract checking and validating process in tunefs.ocfs2.take 3

Sunil Mushran Sunil.Mushran at oracle.com
Wed Jan 2 19:01:51 PST 2008


Tao Ma wrote:
> In the main function of tunefs.ocfs2, there are a large
> number of checking and validating process. They are seperated
> and can be moved out of "main" so that future online resize
> can skip these check easily. So add 2 new function, volume_check
> and validate_parameter to organize the complicated process.
>
> There are also 2 minor changes in this patch:
> 1. the print of "Adding backup superblock for the volume" are moved to
>    validate process as others.
> 2. remove_slot_check is moved into function volume_check as it does
>    the check work while it was in validate process.
>
> Signed-off-by: Tao Ma <tao.ma at oracle.com>
> --
Signed-off-by: Sunil Mushran <sunil.mushran at oracle.com>

Remind me... some of the error messages need some polishing.
Nothing big. I can handle that later.



More information about the Ocfs2-tools-devel mailing list