[Ocfs2-tools-devel] Re: [PATCH 1/4] build: Set standard gcc warning switches in Config.make.in

[Joel Becker]

> build: Set standard gcc warning switches in Config.make.in
> 
> The vast majority of warnings set by individual Makefiles in ocfs2-tools are
> redundant. We can just pick a default set of warnings which all programs are
> safe to inherit. The change to actually use the CFLAGS from Config.make.in
> will come in a later patch.
> 
> Signed-off-by: Mark Fasheh <mark.fasheh at oracle.com>

Signed-off-by: Joel Becker <joel.becker at oracle.com>

> ---
>  Config.make.in |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/Config.make.in b/Config.make.in
> index af829c6..6d79148 100644
> --- a/Config.make.in
> +++ b/Config.make.in
> @@ -43,7 +43,11 @@ CPP = @CPP@
>  AR = @AR@
>  RANLIB = @RANLIB@
>  
> +WARNINGS = -Wall -Wstrict-prototypes -Wmissing-prototypes \
> +	   -Wmissing-declarations
> +
>  CFLAGS = @CFLAGS@
> +CFLAGS += $(WARNINGS)
>  CPPFLAGS = @CPPFLAGS@
>  LDFLAGS = @LDFLAGS@ 
>  
> -- 
> 1.5.3.6
> 

-- 

"I always thought the hardest questions were those I could not answer.
 Now I know they are the ones I can never ask."
			- Charlie Watkins

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127