[Ocfs2-tools-devel] Re: [Ocfs2-devel] [patch 1/1] offline de-fragmentation tool

[wengang wang]

Tao Ma wrote:
> wengang wang Wrote:
>>>> +
>>>> +/* find the record --ocfs2_extent_rec, which blkno is 
>>>> old_data_blkno, change blkno to +new_data_blkno
>>>> +*/
>>>> +static inline int modify_file_meta(uint64_t file_blkno, uint64_t 
>>>> from_blkno,
>>>> +                    uint64_t to_blkno)
>>>>   
>>> Why go through the file once again? Since you have already iterate 
>>> all the files, you may record the information there. So that you 
>>> don't need to iterate it now the second time.
>> can't hold all meta in memory for memory limitation. have to iterate 
>> it again.
> You only need to store the blkno and the type(inode or extent block), 
> not the whole metadata. They are just a few bytes. You now save an 
> extent rec,. so why not add them?
ah, yea, good idea.