[Ocfs2-tools-devel] [PATCH] libtools-internal: Move verbosef to an internal library.

[Joel Becker]

On Fri, Aug 29, 2008 at 04:47:33PM +0800, Tao Ma wrote:
>
>
> Joel Becker wrote:
>> On Fri, Aug 29, 2008 at 03:53:19PM +0800, Tao Ma wrote:
>>>> +/* Prints the version of ocfs2ne */
>>> Now it isn't ocfs2ne any more. ;)
>>
>> 	hehe!
>>
>>> Other parts looks ok.
>>> btw, I can't compile it in my box. So do you miss something?
>>>
>>> ...
>>> make[1]: Entering directory `/home/taoma/ocfs2-tools/libtools-internal'
>>> gcc -O2 -Wall -Wstrict-prototypes -Wmissing-prototypes   
>>> -Wmissing-declarations -pipe -fPIC    -I. -I../include   
>>> -DVERSION=\"1.4.1\"  -MD -MP -MF ./.verbose.d -o verbose.o -c 
>>> verbose.c
>>> verbose.c:28:21: error: com_err.h: No such file or directory
>>> In file included from verbose.c:30:
>>> ../include/tools-internal/verbose.h:65: error: expected ‘)’ before ‘code’
>>
>> 	It should be et/com_err.h.  I wonder why it worked here?
> yeah, it works now. So with this 2 modifications, you can use my sob.
> Don't need to send the patch twice since they are both minor issues.

Thanks!
Joel

-- 

"I'm so tired of being tired,
 Sure as night will follow day.
 Most things I worry about
 Never happen anyway."

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127