[Ocfs2-tools-devel] tunefs.ocfs2: build tunefs.ocfs2 binary directly

[Joel Becker]

On Mon, Aug 25, 2008 at 09:32:41AM -0700, Mark Fasheh wrote:
> The rename of the sources (during the tunefs rewrite) is fine but as far as
> I can tell it's not really necessary to rename the binary itself. Sure, we
> can symlink - but if there's no compelling technical reason for the rename,
> then IMHO we shouldn't add the extra complexity.

	It's not a symlink, it's a hardlink, making tunefs.ocfs2 exactly
the binary.  I did it that way because I got to liking "./ocfs2ne" kind
of like "tune2fs" vs "tunefs.ext2".  But I didn't go so far as to
install the ocfs2ne-named file in /sbin, and if we don't want to do that,
this patch is just fine.

Joel

> Signed-off-by: Mark Fasheh <mfasheh at suse.com>
> ---
>  tunefs.ocfs2/Makefile |    5 +----
>  1 files changed, 1 insertions(+), 4 deletions(-)
> 
> diff --git a/tunefs.ocfs2/Makefile b/tunefs.ocfs2/Makefile
> index c0e70af..6c888dc 100644
> --- a/tunefs.ocfs2/Makefile
> +++ b/tunefs.ocfs2/Makefile
> @@ -91,13 +91,10 @@ libocfs2ne.a: $(LIBOCFS2NE_OBJS)
>  	$(AR) r $@ $^
>  	$(RANLIB) $@
>  
> -ocfs2ne: $(OCFS2NE_OBJS) libocfs2ne.a $(LIBOCFS2_DEPS) $(LIBO2DLM_DEPS) $(LIBO2CB_DEPS)
> +tunefs.ocfs2: $(OCFS2NE_OBJS) libocfs2ne.a $(LIBOCFS2_DEPS) $(LIBO2DLM_DEPS) $(LIBO2CB_DEPS)
>  	$(LINK) $(LIBOCFS2_LIBS) $(UUID_LIBS) $(LIBO2DLM_LIBS) \
>  		$(LIBO2CB_LIBS) $(COM_ERR_LIBS)
>  
> -tunefs.ocfs2: ocfs2ne
> -	ln -f ocfs2ne tunefs.ocfs2
> -
>  CLEAN_RULES = clean-err
>  
>  clean-err:
> -- 
> 1.5.4.1
> 

-- 

"The whole principle is wrong; it's like demanding that grown men 
 live on skim milk because the baby can't eat steak."
        - author Robert A. Heinlein on censorship

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127