[Ocfs2-tools-devel] [PATCH 3/3] Enhancement for mkfs-test to check incompatible features:check for xattr support

[Marcos E. Matsunaga]

Looks good to me.

Regards,

Marcos Eduardo Matsunaga

Oracle USA
Linux Engineering

“The statements and opinions expressed here are my own and do not
necessarily represent those of Oracle Corporation.”



tristan.ye wrote:
> Add new testcases in mkfs-test:check xattr support for
> mkfs.
>
> Signed-off-by: Tristan Ye <tristan.ye at oracle.com>
> ---
>
> Index: ocfs2-test/programs/mkfs-tests/mkfs-test.sh
> ===================================================================
> --- ocfs2-test/programs/mkfs-tests/mkfs-test.sh	(revision 183)
> +++ ocfs2-test/programs/mkfs-tests/mkfs-test.sh	(working copy)
> @@ -407,6 +407,28 @@
>  do_fsck ${OUT}
>  testnum=$[$testnum+1]
>  
> +### Test option '--fs-features=xattr'
> +TAG=mkfs_test_${testnum}
> +OUT=${outdir}/${TAG}.log
> +echo "Test ${testnum}: --fs-features=xattr"
> +label="Oracle_Home"
> +echo -n "mkfs ..... "
> +${MKFS} --fs-features=xattr -x -F -b 4K -C 4K -N 2 -L ${label}
> ${device} 262144 >>${OUT} 2>&1
> +echo "OK"
> +echo -n "verify ..... "
> +${DEBUGFS} -R "stats" ${device} >>${OUT} 2>&1
> +${DEBUGFS} -R "stats" ${device}|${GREP} -i "Feature Incompat"|${GREP}
> -q "Xattr"
> +RC=$?
> +if [ "${RC}" != "0" ]; then
> +    echo "ERROR: Did not find Xattr Flag on superblock " >> ${OUT}
> +    echo "" >> ${OUT}
> +    echo "FAILED. Errors in ${OUT}"
> +else
> +    echo "OK"
> +fi
> +do_fsck ${OUT}
> +testnum=$[$testnum+1]
> +
>  ### Test bitmap_cpg change
>  TAG=mkfs_test_${testnum}
>  OUT=${outdir}/${TAG}.log
>
>
> _______________________________________________
> Ocfs2-tools-devel mailing list
> Ocfs2-tools-devel at oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-tools-devel
>   
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://oss.oracle.com/pipermail/ocfs2-tools-devel/attachments/20080821/1561d8ef/attachment.html