[Ocfs2-tools-devel] [PATCH 3/3] ocfs2_controld.pcmk: Complete implementation of kill_stack_node()

[Joel Becker]

On Thu, Aug 21, 2008 at 10:15:05AM -0700, Mark Fasheh wrote:
> This plugs ocfs2_controld.pcmk into the pacemaker-provided stonith library,
> so that kill_stack_node() can initiate fencing of a misbehaving node.
> 
> Signed-off-by: Andrew Beekhof <abeekhof at suse.de>
> Signed-off-by: Mark Fasheh <mfasheh at suse.com>

	I like this!  One comment:

> +	stonithd_ci = connection_add(stonithd_fd, process_stonithd,
> +				     dead_stonithd);	
> +	return TRUE;

	connection_add() can return an error (ci<0).  That needs to be
checked.

Joel

-- 

"I don't know anything about music. In my line you don't have
 to."
        - Elvis Presley

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127