[Ocfs2-tools-devel] [PATCH 22/22] tunefs rework: Link ocfs2ne into the build.

[Joel Becker]

On Fri, Aug 08, 2008 at 04:17:22PM -0700, Mark Fasheh wrote:
> On Fri, Aug 08, 2008 at 04:10:11PM -0700, Joel Becker wrote:
> > > That's one way to do it. How much git history would be preserved if you
> > > made the changes to the existing sources though?
> > 
> > 	I'm not sure what you mean here?
> 
> Oh, I'm just curious if git can help us out regarding maintaining some sort
> of change history if you make the changes by just deleting code and moving
> it into the new files as you go, as opposed to one big commit which just
> renames your new files over the old ones.

	I don't intend to rename the new files.  Just leave them as is,
remove the old files, and link the new binary as tunefs.ocfs2.
	If you mean history like how features.c split off into
feature_xxx.c and op_features.c, I found that even the most unchanged
file (list_sparse) foiled git rename detection.  Changing the verbosity
functions was enough.

> Hmm, though I suppose redoing the top-level logic in tunefs would be
> difficult in a piecemeal fashion...

	I see what you mean.  I spent ten minutes in the beginning
thinking how to redo tunefs.ocfs2.c piecemeal.  Then I went and did it
this way :-)

Joel

-- 

"Hey mister if you're gonna walk on water,
 Could you drop a line my way?"

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127