[Ocfs2-tools-devel] [PATCH 0/22] tunefs rework

[Joel Becker]

On Wed, Aug 06, 2008 at 06:48:38PM -0700, Mark Fasheh wrote:
> On Wed, Aug 06, 2008 at 05:29:16PM -0700, Mark Fasheh wrote:
> > > 3) "It's quiet."  "Yeah, too quiet."
> > > 
> > >    The old tunefs.ocfs2 was very chatty.  This doesn't fit with a normal
> > >    command-line program that only tells you when something goes wrong.
> > >    The new code has proper verbosity levels - just keep adding '-v' for
> > >    more noise.  Say '-i' like cp(1), mv(1), and rm(1) if you want
> > >    ocfs2ne to ask you questions.
> > 
> > This is a great improvement btw  :)
> 
> ... and after having read the code a bit - is there any reason why we can't
> move some of that functionality (things like verbosef(), the
> should-i-interact functions, etc) into libocfs2 or some other library that's
> accessible to other ocfs2-tools programs? o2image in particular needs some
> love in this area...

	Like a libutil sort of deal?  We could.  (note that the name
conflicts with fsck's verbosef().  I liked the name, though fsck's
verbosef() is specific to fsck functionality).

Joel

-- 

"When arrows don't penetrate, see...
 Cupid grabs the pistol."

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127