[Ocfs2-tools-devel] [PATCH] ocfs2-tools: add error message to mount.ocfs2 when mount point is invalid. [V3]

Mark Fasheh mfasheh at suse.com
Mon Aug 4 15:36:42 PDT 2008


On Fri, Aug 01, 2008 at 09:37:36AM +0800, Coly Li wrote:
> diff --git a/mount.ocfs2/mount.ocfs2.c b/mount.ocfs2/mount.ocfs2.c
> index a97b4cb..eb8e336 100644
> --- a/mount.ocfs2/mount.ocfs2.c
> +++ b/mount.ocfs2/mount.ocfs2.c
> @@ -382,9 +382,21 @@ int main(int argc, char **argv)
>   			o2cb_complete_group_join(&cluster, &desc, errno);
>   		}
>   		block_signals (SIG_UNBLOCK);
> -		com_err(progname, ret, "while mounting %s on %s. "
> -			"Check 'dmesg' for more information on this error.",
> -			mo.dev, mo.dir);
> +
> +		/* complain mount failure */
> +		if (lstat(mo.dir, &statbuf))

statbuf is undeclared, and so this patch doesn't compile. None the less, I
fixed and committed. Please be more careful next time.

Thanks,
	--Mark

--
Mark Fasheh



More information about the Ocfs2-tools-devel mailing list