[Ocfs2-tools-devel] [PATCH 5/6] Resend: Add unwritten extent support in ocfs2-tools, take 2

[tao.ma]

Joel Becker wrote:
>> In ocfs2_block_iterate, we just iterate all the extent records and give the 
>> block num to the user's callback.  As for unwritten extent record, do you 
>> think we should add a new parameter in the callback's definition that this 
>> block exist in a unwritten extents? I am not quite sure of it.
>>     
>
> 	Oho!  We have a problem.  In ocfs2_read_whole_file, we have a
> reader function (read_whole_func) that doesn't check unwritten extents.
> That needs to be added to patch #6.  Of course, how to tell the
> function?
> 	Also, extras/set_random_bits.c uses it.  I think that the
> fsck.ocfs2 users are safe (symlinks and directories).
>   
Yes, that is what I worry about. the callback has no idea of whether the 
block is marked as unwritten. So maybe as I have said previously, add a 
new parameter in callback's definition that this block exists in an 
unwritten extent?
Do you have any suggestion or just agree with me? :)


<http://www.oracle.com/cdc/>