[Ocfs2-tools-devel] [PATCH] ocfs2-tools: Small cleanup for hb device support

[Sunil Mushran]

Was this sob-ed?

Mark Fasheh wrote:
> On Wed, Sep 19, 2007 at 04:51:55PM -0700, Sunil Mushran wrote:
>   
>> 	if (signal(SIGTERM, handle_signal) == SIG_ERR) {
>> -		fprintf(stderr, "Could not set SIGTERM\n");
>> +		com_err(opts.progname, 0, "Could not set SIGTERM");
>> 		exit(1);
>> 	}
>>
>> 	if (signal(SIGINT, handle_signal) == SIG_ERR) {
>> -		fprintf(stderr, "Could not set SIGINT\n");
>> +		com_err(opts.progname, 0, "Could not set SIGINT");
>> 		exit(1);
>> 	}
>>
>>
>> Are you referring to the above change or more?
>>     
>
> No - it was the changes to how options flags were managed:
>
> +       if (opts.queryfmt)
> +               open_flags |= OCFS2_FLAG_RO;
> +       else
> +               open_flags |= OCFS2_FLAG_RW | OCFS2_FLAG_STRICT_COMPAT_CHECK;
>
>
> But wait, are those required for this patch? Could be that I didn't quite
> understand that part...
> 	--Mark
>
> --
> Mark Fasheh
> Senior Software Developer, Oracle
> mark.fasheh at oracle.com
>