[Ocfs2-tools-devel] [PATCH 1/2] Return zero when we find the cache in io_cache_read_one_block.

Joel Becker Joel.Becker at oracle.com
Fri Oct 19 13:24:19 PDT 2007


On Fri, Oct 19, 2007 at 02:57:08PM +0800, Tao Ma wrote:
> When we find the cache in io_cache_read_one_block, we will copy
> the date cache and return directly, but the return value isn't
> initialized. So initialize it to "0" to return.
> 
> Signed-off-by: Tao Ma <tao.ma at oracle.com>

Signed-off-by: Joel Becker <joel.becker at oracle.com>

Brown-paper-bag: Joel Becker <joel.becker at oracle.com>

> ---
>  libocfs2/unix_io.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/libocfs2/unix_io.c b/libocfs2/unix_io.c
> index de38611..65f2791 100644
> --- a/libocfs2/unix_io.c
> +++ b/libocfs2/unix_io.c
> @@ -238,7 +238,7 @@ static struct io_cache_block *io_cache_pop_lru(struct io_cache *ic)
>  static errcode_t io_cache_read_one_block(io_channel *channel, int64_t blkno,
>  					 char *data)
>  {
> -	errcode_t ret;
> +	errcode_t ret = 0;
>  	struct io_cache *ic = channel->io_cache;
>  	struct io_cache_block *icb;
>  
> -- 
> 1.5.3.2.g4f337
> 
> _______________________________________________
> Ocfs2-tools-devel mailing list
> Ocfs2-tools-devel at oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-tools-devel

-- 

"Nobody loves me,
 Nobody seems to care.
 Troubles and worries, people,
 You know I've had my share."

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127



More information about the Ocfs2-tools-devel mailing list