[Ocfs2-tools-devel] [PATCH] Add extent flag as the parameter to block iteration function.

Mark Fasheh mark.fasheh at oracle.com
Tue Oct 9 21:38:44 PDT 2007


On Tue, Oct 09, 2007 at 08:35:51PM -0700, Mark Fasheh wrote:
> How useful do we think ocfs2_read_whole_file() is? It really shouldn't be
> too much to fix it up to just use ocfs2_file_read() directly. I guess the
> different between this and the iterate functions is that the iterate
> functions had no clear and obvious path to working with the new file system
> features - this can still work pretty easily.

On second thought, I think for now, we should just leave it as-is in this
patch. Ocfs2_read_while_file() should work fine for holes and unwritten
extents now since the buffer is zero'd when allocated. We'll just have to
update it to use ocfs2_file_read() in the patches for inline-data.
	--Mark

--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh at oracle.com



More information about the Ocfs2-tools-devel mailing list