[Ocfs2-tools-devel] [patch 5/9] Add slot remove mechanism in tunefs.ocfs2, take 3

[tao.ma]

Sunil Mushran wrote:
> 2.
> +       if (action == RELINK_EXTENT_ALLOC)
> +               ret = ocfs2_lookup_system_inode(fs,
> +                                               
> EXTENT_ALLOC_SYSTEM_INODE,
> +                                               removed_slot, &blkno);
> +       else
> +               ret = ocfs2_lookup_system_inode(fs,
> +                                               INODE_ALLOC_SYSTEM_INODE,
> +                                               removed_slot, &blkno);
> +       if (ret)
> +               goto bail;
>
> Open ended else can create problems later. No harm making it more
> explicit and returning an error if unknown.
Sorry, I don't know what you mean. You mean I should change it to:
       if (action == RELINK_EXTENT_ALLOC) {
               ret = ocfs2_lookup_system_inode(fs,
                                               EXTENT_ALLOC_SYSTEM_INODE,
                                               removed_slot, &blkno);
              if (ret)
                   goto bail;

     }
       else {
               ret = ocfs2_lookup_system_inode(fs,
                                               INODE_ALLOC_SYSTEM_INODE,
                                               removed_slot, &blkno);
              if (ret)
                   goto bail;
    }    
> Do you have the test patch for viewing?
I will send out the test patch and script today.